Prepare Release 2.6.0 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rpbaltazar
commented
May 11, 2020
•
rpbaltazar
commented
- [Resolves After switch callback not working with nil argument #42]
- [Resolves Support configuration for skip checking of schema existence before switching #26]
- [Resolves Add tenant info to console boot? #41]
- [Resolves Custom Console deprecation warning #37]
- Updated github actions configuration to run on PRs as well
…s responsible for reseting if needed
- Each adapter is responsible for resetting the tenant info based on the way they behave - `switch` relies on the `connect_to_new` implementation of each of the adapters - Added test coverage for raised issue
… checking for tenant presence
…fied while running tests
…tence before switching This is configurable by setting: tenant_presence_check. It defaults to true in order to maintain the original gem behavior. This is only checked when using one of the PostgreSQL adapters. The original gem behavior, when running switch would look for the existence of the schema before switching. This adds an extra query on every context switch. While in the default simple scenarios this is a valid check, in high volume platforms this adds some unnecessary overhead which can be detected in some other ways on the application level. Setting this configuration value to false will disable the schema presence check before trying to switch the context. Apartment.configure do |config| tenant_presence_check = false end
- updated custom console to include welcome message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.