Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Resolves #9] Cleanup rubocop todo #8

Merged
merged 37 commits into from
Feb 17, 2020
Merged

[Resolves #9] Cleanup rubocop todo #8

merged 37 commits into from
Feb 17, 2020

Conversation

rpbaltazar
Copy link
Contributor

No description provided.

@rpbaltazar
Copy link
Contributor Author

@jean-francois-labbe I'm generally a big fan of standards. I maintain the gem 'perx-rubocop` that is the one I usually use as default settings. Since you've been investing your time in this as well, do you have any issues with it?

@rpbaltazar rpbaltazar changed the title [Hotfix] Cleanup rubocop todo [Resolves #9] Cleanup rubocop todo Feb 16, 2020
@jean-francois-labbe
Copy link

@jean-francois-labbe I'm generally a big fan of standards. I maintain the gem 'perx-rubocop` that is the one I usually use as default settings. Since you've been investing your time in this as well, do you have any issues with it?

@rpbaltazar That's a really good idea, to ease contribution the code must comply with a standard. I'm used to rubocop standardrb and rufo. whatever the tool you choose, I'm ok with that.

@jean-francois-labbe
Copy link

@rpbaltazar One thing that would be nice is to fix the travis-ci config in order to have a Green CI status, it would reassure users and enable faster tests status analysis (today I need to go check why the status is Red), easier merge request approval.

@rpbaltazar
Copy link
Contributor Author

I’ll wrap up the rubocop and have it merged then.
I have not checked right now, but The red was because of a bug in one of the rails versions. I think that for that specific case we can move it to the section of the “allowed to fail” until the rails fix version is released.

@rpbaltazar rpbaltazar mentioned this pull request Feb 17, 2020
Merged
rpbaltazar added a commit that referenced this pull request Feb 17, 2020
@rpbaltazar
Merge pull request #10 from rails-on-services/fix-rubocop-usage
92960de 
- Fixes CI runs:
  - One of the rails versions [had a bug](rails/rails#38137) and causes the CI to fail. I've moved it to the allowed failures.
  - I think we should deprecate these versions as they are EOL. => New ticket to be created
- Fixes rubocop installation - I had not realized when I merged rubocop installation that I was breaking all CI (I'm sorry for the rushed decision). This fixes the dependencies and all CI should be passing.
- Adds rubocop to github actions. All the rubocop failures will be fixed with #8
@rpbaltazar
WIP - starting to cleanup
40d3350
@rpbaltazar
WIP - ran autocorrect
b335c2a
@rpbaltazar
[Hotfix] Fixed modifier indentation
017c7a8
@rpbaltazar
WIP - fixed braces around hash params
7d66739
@rpbaltazar
WIP - fixed array of strings
0cadb66
@rpbaltazar
[Hotfix] fixed array of strings for schemas rb
8ba3245
@rpbaltazar
WIP - removed a few more broken rules in rubocop
b437189
@rpbaltazar
WIP - cleanup a few more rubocop
2bc9f84
@rpbaltazar
WIP - fixed a couple more of rubocops
f6ec075
@rpbaltazar
WIP -
8d127c5
@rpbaltazar
WIP - removed extra blank lines
a22737d
@rpbaltazar
WIP - fixed EmptyLinesAroundBlockBody
7f68591
@rpbaltazar
WIP - Fixed EmptyLinesAroundModuleBody
e7cd59b
@rpbaltazar
WIP - ran more auto correct
ea46027
@rpbaltazar
WIP - fixed SpaceBeforeBlockBraces
9495f79
@rpbaltazar
WIP - fixed spacing related issues
127883b
@rpbaltazar
WIP - ran some more auto correct
edf9d24
@rpbaltazar
WIP - fixed dynamic find by
bacd618
@rpbaltazar
WIP - fixed rails output and preferred alias method
d2e8248
@rpbaltazar
WIP - sorted gemfiels
7fc7d33
@rpbaltazar
WIP - fixed unused argument
ea8f97c
@rpbaltazar
WIP - fixed yaml safe load
6c7d1fe
@rpbaltazar
WIP - fixed block delimiters
6efd1e5
@rpbaltazar rpbaltazar merged commit 79e6eb4 into development Feb 17, 2020
@rpbaltazar rpbaltazar deleted the fix-rubocop branch February 17, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpbaltazar @jean-francois-labbe