-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove multi_json as dependency in favor of std-lib json #213
Conversation
Looks fine, but lots of issues with CI. Let's get the MultiJson removal and CI fixes in different PRs. |
I merged the dependency removal. However I tried to really update the CI matrix but it's a huge pain -_-. |
The failure on edge is also on 7.2. I dug a bit as to what is going on, but I'm a bit tired. |
@byroot can I help you get this released as a new version? What's missing? |
The CI would need to be fixed, tests are no longer passing against Rails edge because of some change in the router. I know the gem works fine, it's just a test helper that was reaching into Action Dispatch internals that need to be refactored/updated. |
This PR is almost identical to #212 but for security reasons we want to maintain our own fork.
CI is also updated to include newer Ruby and Rails versions (currently failing on
edge
but that is expected).