Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize bin/dev from jsbundling-rails to cssbundling-rails #151

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

dorianmarie
Copy link
Contributor

There are different bin/dev being generated by cssbundling-rails and jsbundling-rails

See rails/jsbundling-rails#174

dev: Use an affirmative conditional

...and avoid regex in match.

(Try a gem list ails vs a gem list --exact ails to see what I mean.)

There are different bin/dev being generated by cssbundling-rails and jsbundling-rails

See rails/jsbundling-rails#174

> dev: Use an affirmative conditional
>
> ...and avoid regex in match.
>
> (Try a gem list ails vs a gem list --exact ails to see what I mean.)
@dorianmarie
Copy link
Contributor Author

dorianmarie commented Jan 19, 2024

Here is what I was getting:

Add bin/dev to start foreman
    conflict  bin/dev
Overwrite /Users/dorianmariefr/src/traffic-jam/bin/dev? (enter "h" for help) [Ynaqdhm] d
  #!/usr/bin/env sh
  
- if ! gem list foreman -i --silent; then
+ if gem list --no-installed --exact --silent foreman; then
    echo "Installing foreman..."
    gem install foreman
  fi
  
  # Default to port 3000 if not specified
  export PORT="${PORT:-3000}"
  
  exec foreman start -f Procfile.dev "$@"
Retrying...
Overwrite /Users/dorianmariefr/src/traffic-jam/bin/dev? (enter "h" for help) [Ynaqdhm] 

cc: @dhh

@dhh dhh merged commit 02caad4 into rails:main Jan 19, 2024
@dorianmariecom
Copy link
Contributor

@dhh could you release a new version please?

@dhh
Copy link
Member

dhh commented Jan 21, 2024

Done.

@dorianmarie
Copy link
Contributor Author

Thanks @dhh you dat best :)

@dorianmarie
Copy link
Contributor Author

See you at RailsConf?

@dorianmarie dorianmarie deleted the patch-1 branch January 22, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants