Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Fix typo (missing space) on Rails.application.config.dartsass.build_options #54

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

navidemad
Copy link

In the README.md:
Rails.application.config.dartsass.build_options << "--no-charset" << "--quiet-deps"

Produces with a fresh app:

02:56:29 css.1  | Could not find an option named "no-source-map--no-charset--quiet-deps".
02:56:29 css.1  |
02:56:29 css.1  | Usage: sass <input.scss> [output.css]
02:56:29 css.1  |        sass <input.scss>:<output.css> <input/>:<output/> <dir/>

By default Rails.application.config.dartsass.build_options is:
--style=compressed --no-source-map

We have to add space before the first of each dashes.
Rails.application.config.dartsass.build_options << " --no-charset" << " --quiet-deps"

@ntkme
Copy link
Contributor

ntkme commented Jan 25, 2024

This README change was due to a yet to be release change on main branch which changed the default from a string "--style=compressed --no-source-map" to an array ["--style=compressed", "--no-source-map"], with the new array form you don't need that extra whitespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants