Skip to content

Commit

Permalink
Allow single quotes in config/importmaps.rb (#147)
Browse files Browse the repository at this point in the history
  • Loading branch information
UweKubosch authored Nov 20, 2022
1 parent c9d3925 commit b93ac63
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/importmap/packager.rb
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def vendored_pin_for(package, url)
end

def packaged?(package)
importmap.match(/^pin "#{package}".*$/)
importmap.match(/^pin ["']#{package}["'].*$/)
end

def download(package, url)
Expand Down Expand Up @@ -102,7 +102,7 @@ def remove_existing_package_file(package)

def remove_package_from_importmap(package)
all_lines = File.readlines(@importmap_path)
with_lines_removed = all_lines.select { |line| line !~ /pin "#{package}"/ }
with_lines_removed = all_lines.grep_v(/pin ["']#{package}["']/)

File.open(@importmap_path, "w") do |file|
with_lines_removed.each { |line| file.write(line) }
Expand Down
22 changes: 22 additions & 0 deletions test/packager_single_quotes_test.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
require "test_helper"
require "importmap/packager"

class Importmap::PackagerSingleQuotesTest < ActiveSupport::TestCase
setup do
@single_quote_config_name = Rails.root.join("config/importmap_with_single_quotes.rb")
File.write(@single_quote_config_name, File.read(Rails.root.join("config/importmap.rb")).tr('"', "'"))
@packager = Importmap::Packager.new(@single_quote_config_name)
end

teardown { File.delete(@single_quote_config_name) }

test "packaged? with single quotes" do
assert @packager.packaged?("md5")
assert_not @packager.packaged?("md5-extension")
end

test "remove package with single quotes" do
assert @packager.remove("md5")
assert_not @packager.packaged?("md5")
end
end

0 comments on commit b93ac63

Please sign in to comment.