Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated module_name regexp to not match incorrect indexes #238

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

Caleb-T-Owens
Copy link
Contributor

This updates the regex used to identify index files to ensure that modules like foo/special_index don't get mapped to foo.

The cause of the problem was that the previous regex matched 1 or 0 / characters, which meant anything followed by index and the end of the string, would qualify. We now ensure that we match either the start of the string or /

@mylons
Copy link

mylons commented Feb 9, 2024

looks good to me! looks better than my solution i think: mylons@c5cb32b

@rafaelfranca rafaelfranca merged commit 2ecde30 into rails:main Apr 19, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

files ending in _index.js have index replaced with an empty string
3 participants