Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JRuby 9.2.0 shows LoadError: no such file to load -- io/console/size #32318

Closed
yahonda opened this issue Mar 22, 2018 · 11 comments
Closed

JRuby 9.2.0 shows LoadError: no such file to load -- io/console/size #32318

yahonda opened this issue Mar 22, 2018 · 11 comments
Labels

Comments

@yahonda
Copy link
Member

yahonda commented Mar 22, 2018

CI with jruby-head for actionpack has been failing at Travis https://travis-ci.org/rails/rails/jobs/356541503

Steps to reproduce

$ cd actionpack
$ bundle install
$ bundle exec ruby -Itest test/journey/routes_test.rb

I think this is not specific to routes_test.rb. It could reproduce almost every test.

Expected behavior

Tell us what should happen

Actual behavior

$ bundle exec ruby -Itest test/journey/routes_test.rb
LoadError: no such file to load -- io/console/size
             require at org/jruby/RubyKernel.java:969
    block in require at /home/yahonda/git/rails/activesupport/lib/active_support/dependencies.rb:283
     load_dependency at /home/yahonda/git/rails/activesupport/lib/active_support/dependencies.rb:249
             require at /home/yahonda/git/rails/activesupport/lib/active_support/dependencies.rb:283
              <main> at /home/yahonda/git/rails/actionpack/lib/action_dispatch/routing/inspector.rb:4
             require at org/jruby/RubyKernel.java:969
     block in (root) at /home/yahonda/git/rails/activesupport/lib/active_support/dependencies.rb:1
             require at /home/yahonda/git/rails/activesupport/lib/active_support/dependencies.rb:283
     load_dependency at /home/yahonda/git/rails/activesupport/lib/active_support/dependencies.rb:249
              <main> at /home/yahonda/git/rails/activesupport/lib/active_support/dependencies.rb:283
     block in (root) at /home/yahonda/git/rails/actionpack/lib/action_dispatch/middleware/debug_exceptions.rb:5
              (root) at /home/yahonda/git/rails/actionpack/test/abstract_unit.rb:1
           build_app at /home/yahonda/git/rails/actionpack/test/abstract_unit.rb:105
          initialize at /home/yahonda/git/rails/actionpack/lib/action_dispatch/middleware/stack.rb:47
  <class:initialize> at /home/yahonda/git/rails/actionpack/test/abstract_unit.rb:93
              <main> at /home/yahonda/git/rails/actionpack/test/abstract_unit.rb:103
             require at org/jruby/RubyKernel.java:969
              <main> at /home/yahonda/git/rails/actionpack/test/abstract_unit.rb:115
$

System configuration

Rails version:master branch

Ruby version:jruby 9.2.0.0-SNAPSHOT (2.4.1) 2018-03-15 36b44df Java HotSpot(TM) 64-Bit Server VM 25.161-b12 on 1.8.0_161-b12 [linux-x86_64]

@yahonda
Copy link
Member Author

yahonda commented Mar 22, 2018

GEM=am,amo,aj is also getting the same LoadError: no such file to load -- io/console/size https://travis-ci.org/rails/rails/jobs/356541504

@yahonda
Copy link
Member Author

yahonda commented Mar 22, 2018

cc @headius @enebo

@headius
Copy link
Contributor

headius commented Mar 22, 2018

A new addition to the io/console library it seems?

@yahonda
Copy link
Member Author

yahonda commented Mar 23, 2018

Doing git bisect and found #32160 requires "io/console/size"

@enebo
Copy link

enebo commented Mar 23, 2018

@yahonda a more useful reference may be when ruby stdlib included it version-wise. The fact rails includes it is a big deal though.

@bogdanvlviv
Copy link
Contributor

bogdanvlviv commented Mar 23, 2018

io/console/size was added in ruby/ruby@aef01ee

@y-yagi y-yagi added the JRuby label Mar 26, 2018
@y-yagi
Copy link
Member

y-yagi commented Mar 26, 2018

Workaround:
IO.console_size is wrapper for IO.console.winsize. Therefore, if can not use console_size, can avoid using console.winsize.
Ref: Workaround for JRuby console size.

@headius
Copy link
Contributor

headius commented Mar 26, 2018

Ahh it's just a pure-Ruby item. We are likely just not copying it from MRI. I'll get that fixed.

headius added a commit to jruby/jruby that referenced this issue Mar 27, 2018
headius added a commit to jruby/jruby that referenced this issue Mar 27, 2018
@headius
Copy link
Contributor

headius commented Mar 27, 2018

This is now fixed on JRuby master.

headius added a commit to jruby/jruby that referenced this issue Mar 27, 2018
@robin850
Copy link
Member

Awesome folks ! Thanks for reporting @yahonda and thanks for the quick fix @headius !

@yahonda
Copy link
Member Author

yahonda commented Mar 28, 2018

Validated the fix https://travis-ci.org/rails/rails/jobs/359123642 Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants