Skip to content

Commit

Permalink
We are not using jruby/truffleruby to deploy api docs
Browse files Browse the repository at this point in the history
  • Loading branch information
@zzak
zzak committed Mar 6, 2023
1 parent cb6b830 commit 59bd616
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/test.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ jobs:
- '3.1'
- '3.2'
- 'ruby-head'
- 'jruby-head'
- 'truffleruby-head'

steps:
- uses: actions/checkout@v1
Expand Down

5 comments on commit 59bd616

@eregon
Copy link
Contributor

@eregon eregon commented on 59bd616 Mar 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also means not testing sdoc on JRuby and TruffleRuby at all. Fine if intended, but just wanted to mention it in case.

@zzak
Copy link
Member Author

@zzak zzak commented on 59bd616 Mar 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eregon Hey! It's funny you found this 👀 cannot hide from you.. Tests were failing so it was just easier to disable them. While this gem is installable, the main goal is just to deploy api.ror.org which we use CRuby for. I'm not sure we will ever use JRuby for that, and speed is not a concern -- but happy to re-enable it if it helps with your work.

FWIW, JRuby is failing on Rails main (probably 7 too) afaict, which we are using for testing. I'd love that not to be the case, but there is more work to do.

@eregon
Copy link
Contributor

@eregon eregon commented on 59bd616 Mar 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, I found this out because we track regressions in public CIs using truffleruby with https://github.com/eregon/truffleruby-gem-tracker/

The failure on truffleruby is https://github.com/zzak/sdoc/actions/runs/4339206734/jobs/7576576496 I guess
That's due to a Bundler issue: rubygems/rubygems#6435
And that super-recent Bundler is used because you specify bundler: latest.
I think not specifying that would fix that issue, I try it in https://github.com/zzak/sdoc/pull/202

@eregon
Copy link
Contributor

@eregon eregon commented on 59bd616 Mar 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding testing this on truffleruby, it seems valuable since the gem is dependency of quite a few other gems: https://rubygems.org/gems/sdoc/reverse_dependencies

@zzak
Copy link
Member Author

@zzak zzak commented on 59bd616 Mar 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please sign in to comment.