Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from turbolinks to turbo v7.3.0 #195

Merged
merged 5 commits into from
Mar 6, 2023
Merged

Migrate from turbolinks to turbo v7.3.0 #195

merged 5 commits into from
Mar 6, 2023

Conversation

zzak
Copy link
Member

@zzak zzak commented Mar 4, 2023

Similar to rails/rails#45932

@@ -234,7 +234,7 @@ Searchdoc.Panel.prototype = $.extend({}, Searchdoc.Navigation, new function() {
if (window.location.protocol === "file:") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this case can be removed now this is implemented in Turbo, similar to rails/rails#45932 (comment)

@zzak zzak requested a review from p8 March 5, 2023 06:26
@p8
Copy link
Member

p8 commented Mar 5, 2023

Nice!

@zzak zzak merged commit 68ae568 into master Mar 6, 2023
@zzak zzak deleted the migrate-to-turbo branch March 6, 2023 01:55
@zzak zzak added this to the 3.0.0 milestone Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants