Replace source code toggler JavaScript with <details>
#252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces the `javascript:toggleSource(...)` links used to show and hide method source with an inherently toggleable `<details>` element. In addition to reducing JavaScript, this fixes a small horizontal shift that occurred when changing "show" to "hide" (and vice versa). The `external-link.svg` file is from [Feather icons][feather] v4.29.0, and is [licensed under the MIT license][license]. [feather]: https://feathericons.com/ [license]: https://github.com/feathericons/feather/blob/v4.29.0/LICENSE
p8
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces the
javascript:toggleSource(...)links used to show and hide method source with an inherently toggleable<details>element. In addition to reducing JavaScript, this fixes a small horizontal shift that occurred when changing "show" to "hide" (and vice versa).The
external-link.svgfile is from Feather icons v4.29.0, and is licensed under the MIT license.