Fix breadcrumbs for flattened class declarations #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When declaring a class with a flattened name like `class Foo::Bar` rather than `module Foo; class Bar`, RDoc does not return a parent object for `Bar`. Note this only applies to classes. When `Bar` is merely a module, RDoc _does_ return a parent object. That behavior caused `module_breadcrumbs` to return only the class's name in such cases. This commit fixes `module_breadcrumbs` to work around that behavior and always return all breadcrumbs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When declaring a class with a flattened name like
class Foo::Barrather thanmodule Foo; class Bar, RDoc does not return a parent object forBar. Note this only applies to classes. WhenBaris merely a module, RDoc does return a parent object.That behavior caused
module_breadcrumbsto return only the class's name in such cases. This commit fixesmodule_breadcrumbsto work around that behavior and always return all breadcrumbs.