Use type="search" for search input
#322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All other icons that we use are from [Feather icons][feather]. So, for visual consistency, this commit replaces the search input icon with the equivalent icon from Feather icons v4.29.0. The icon is [licensed under the MIT license][license]. [feather]: https://feathericons.com/ [license]: https://github.com/feathericons/feather/blob/v4.29.0/LICENSE
Webkit-based browsers can display a "clear search" button for `type="search"` inputs. However, browsers style the button inconsistently, and some do not display it without additional CSS. This commit adds CSS to ensure the "clear search" button is displayed consistently in Webkit-based browsers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally attempted in 88a61ab but reverted in 68dbaf6 due to an extra magnifying glass icon being shown in Webkit-based browsers.
This commits changes the search input to use
type="search", and adds the necessary CSS to hide the native magnifying glass icon.