Default to cache.yml instead of solid_cache.yml #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll fall back to the old filename if cache.yml doesn't exist.
|
Perfect. @rosapolis would be good to match this in Solid Queue. Was thinking about jobs.yml v queue.yml, and think I prefer queue.yml. You're configuring the queues themselves in that config, not the jobs. They live in app/jobs. And it'll match the config name we have for the dbs. Still fine to then keep bin/jobs to RUN jobs on those queues. |
rosa
added a commit
to rails/solid_queue
that referenced
this pull request
Sep 10, 2024
Following Solid Cache's change in rails/solid_cache#222. As we aren't still in version 1.0, fine to do this as a breaking change for now.
|
Thanks for the mention, @brunoprietog! @dhh got it! |
rosa
added a commit
to rails/solid_queue
that referenced
this pull request
Sep 11, 2024
Following Solid Cache's change in rails/solid_cache#222. As we aren't still in version 1.0, fine to do this as a breaking change for now.
rosa
added a commit
to rails/solid_queue
that referenced
this pull request
Sep 11, 2024
Following Solid Cache's change in rails/solid_cache#222. As we aren't still in version 1.0, fine to do this as a breaking change for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll fall back to the old filename if cache.yml doesn't exist.
cc @dhh