Skip to content

Commit

Permalink
Address Ruby warnings
Browse files Browse the repository at this point in the history
This commit addresses the following warnings appeared at Rails Nightly CI
https://buildkite.com/rails/rails-nightly/builds/1095#019249e3-405c-4c52-ad8d-497f46a5c6a5/1244-1249

```ruby
/usr/local/lib/ruby/gems/3.4.0+0/gems/solid_queue-1.0.0/lib/solid_queue/supervisor/pidfile.rb:32: warning: assigned but unused variable - e
/usr/local/lib/ruby/gems/3.4.0+0/gems/solid_queue-1.0.0/app/models/solid_queue/record.rb:7: warning: ambiguous `**` has been interpreted as an argument prefix
```
  • Loading branch information
yahonda committed Oct 2, 2024
1 parent 29b1847 commit cbf52d9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion app/models/solid_queue/record.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module SolidQueue
class Record < ActiveRecord::Base
self.abstract_class = true

connects_to **SolidQueue.connects_to if SolidQueue.connects_to
connects_to(**SolidQueue.connects_to) if SolidQueue.connects_to

def self.non_blocking_lock
if SolidQueue.use_skip_locked
Expand Down
2 changes: 1 addition & 1 deletion lib/solid_queue/supervisor/pidfile.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def check_status
else
FileUtils.mkdir_p File.dirname(path)
end
rescue Errno::ESRCH => e
rescue Errno::ESRCH => _e
# Process is dead, ignore, just delete the file
delete
rescue Errno::EPERM
Expand Down

0 comments on commit cbf52d9

Please sign in to comment.