Reduce pauses for faster tests #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce the pause and wait times so the test complete faster. It was taking about 144 seconds, now it's 48 seconds.
|
Thanks a lot, @djmb! It was something I had pending to do, review all the pauses and waiting times 😅 |
rosa
approved these changes
Oct 11, 2023
rosa
reviewed
Oct 11, 2023
| @@ -21,7 +21,7 @@ class JobsLifecycleTest < ActiveSupport::TestCase | |||
| @scheduler.start(mode: :async) | |||
| @worker.start(mode: :async) | |||
|
|
|||
| wait_for_jobs_to_finish_for(5.seconds) | |||
There was a problem hiding this comment.
This was a left-over from me trying to debug an error and having to wait very long, so I had time to do some queries to the DB in a separate terminal 😆 I forgot to move them back to something more reasonable.
hms
pushed a commit
to ikyn-inc/solid_queue
that referenced
this pull request
Aug 5, 2024
Implement different features supported by Solid Queue adapters, including a workers view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the pause and wait times so the test complete faster. It was taking about 144 seconds, now it's 48 seconds.
cc @rosa