Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid three-state boolean (TRUE / FALSE / NULL) for solid_queue_recurring_tasks static #283

Merged

Conversation

ksylvest
Copy link
Contributor

This ensures the recurring tasks static is always either TRUE or FALSE (never NULL).

This ensures the recurring tasks static is either TRUE or FALSE.
@ksylvest
Copy link
Contributor Author

A bit unclear on the failure for this:

/home/runner/work/solid_queue/solid_queue/vendor/bundle/ruby/3.2.0/gems/puma-6.4.2/lib/puma/binder.rb:334:in `initialize': Address already in use - bind(2) for "127.0.0.1" port 9222 (Errno::EADDRINUSE)

This might be selenium re-using the port for some reason?

@rosa
Copy link
Member

rosa commented Aug 20, 2024

I retried these tests and they worked just fine. I'm going to remove the puma plugin soon anyway, so that test will go away in any case. I've never hit this one locally, though!

Copy link
Member

@rosa rosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rosa rosa merged commit 5e48e47 into rails:main Aug 20, 2024
4 checks passed
@ksylvest ksylvest deleted the ksylvest/solid-queue-reoccurring-migration-fix branch August 20, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants