Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken rollback migratio in processes' name #293

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

tmimura39
Copy link
Contributor

This is a migration fix added by 76d2c0f.
Since up is a change to NOT NULL, down must undo it.

This is a migration fix added by rails@76d2c0f.
Since `up` is a change to NOT NULL, `down` must undo it.
@tmimura39 tmimura39 marked this pull request as ready for review August 22, 2024 14:24
@tmimura39
Copy link
Contributor Author

tmimura39 commented Aug 22, 2024

Hey @rosa, I did not report the issue as I think it was a simple mistake.
This is not that big a problem, but it is a source of confusion and has been corrected.

Copy link
Member

@rosa rosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, this was totally an oversight from me, thank you so much for catching and fixing 🙏

@rosa rosa merged commit d708605 into rails:main Aug 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants