Wrap polling within instrumentation #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosa
reviewed
Aug 29, 2024
| end | ||
|
|
||
| assert_equal 5, events.size | ||
| assert_event events.last, "polling" |
There was a problem hiding this comment.
Nice! I think you can remove a few variables here, like process, jobs, worker, to make this test simpler, since we don't need them to check anything.
There was a problem hiding this comment.
ok! I removed as many as I could to get a minimum running example. I think process still needs to be there!
gjtorikian
force-pushed
the
instrument-polling
branch
from
7525d3c
to
32f827f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #311. I wasn't sure how interesting the tests should be, but I did my best to show something happening.