-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp recurring tasks configuration and management #338
Commits on Sep 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d7955da - Browse repository at this point
Copy the full SHA d7955daView commit details -
Separate recurring tasks configuration into their own file
`config/recurring.yml`. Run them using the least busy dispatcher (largest polling interval) or a new default dispatcher if none. This also introduces some new options for the CLI, to allow for `--dispatch_only` and `--work_only`, and to skip recurring tasks.
Configuration menu - View commit details
-
Copy full SHA for 0aa1644 - Browse repository at this point
Copy the full SHA 0aa1644View commit details -
Allow configuring queue and priority for recurring tasks
And also setting a description that we can use from Mission Control in the future.
Configuration menu - View commit details
-
Copy full SHA for 03334b1 - Browse repository at this point
Copy the full SHA 03334b1View commit details -
Split recurring scheduling responsibilities into another process
A Scheduler, instead of Dispatcher, that will be created only when there are recurring tasks to run.
Configuration menu - View commit details
-
Copy full SHA for a4467db - Browse repository at this point
Copy the full SHA a4467dbView commit details -
Fix enqueuing recurring task with job outside Solid Queue
Calling `set` on the job class returns a `ConfiguredJob`, and calling `perform_later` on a `ConfiguredJob` doesn't yield the job to a block passed as parameter, so we can't check if the enqueuing was successful or not. To work around this, the only way is to instantiate the job ourselves with the arguments, then call `enqueue` on that, and rely on the result, which would be what `job_class.perform_later` would yield to the block.
Configuration menu - View commit details
-
Copy full SHA for 5d7c949 - Browse repository at this point
Copy the full SHA 5d7c949View commit details -
Configuration menu - View commit details
-
Copy full SHA for de2eca8 - Browse repository at this point
Copy the full SHA de2eca8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c94a36 - Browse repository at this point
Copy the full SHA 3c94a36View commit details -
Use
queue
to specify the queue for a recurring task in configurationTo match worker's `queues` configuration.
Configuration menu - View commit details
-
Copy full SHA for 8d47ed4 - Browse repository at this point
Copy the full SHA 8d47ed4View commit details -
Allow specifying recurring tasks just with a "command"
No need to have a class, can specify this using just a command for which we'd provide a default RecurringtJob class that will just eval the command.
Configuration menu - View commit details
-
Copy full SHA for 90f63c8 - Browse repository at this point
Copy the full SHA 90f63c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8df600d - Browse repository at this point
Copy the full SHA 8df600dView commit details
Commits on Sep 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2e53a64 - Browse repository at this point
Copy the full SHA 2e53a64View commit details