Update Thor CLI options to respect ENV variables for default values #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, thank you! I had broken this, then fixed it, then broken it again 🤦🏻♀️ |
rosa
reviewed
Sep 15, 2024
toydestroyer
force-pushed
the
cli-env-variables
branch
from
8113908
to
3836d55
Compare
toydestroyer
force-pushed
the
cli-env-variables
branch
from
3836d55
to
6b17bb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of
bin/jobsin #308, I noticed that it ignores theSOLID_QUEUE_CONFIGenvironment variable (and the recently introducedSOLID_QUEUE_RECURRING_SCHEDULE), whilerails solid_queue:startstill respects both of them.This PR is my attempt to fix it.
Please let me know if it is worth adding tests for the
SolidQueue::Cli.Also, I hope that the direction is correct, although the logic duplicates
default_optionsfromSolidQueue::Configuration.