New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor ordered_hash_spec #566

Merged

rafaelfranca merged 1 commit into rails:master from colby-swandale:refactor-ordered-hash-spec

Jun 20, 2017

colby-swandale commented Jun 20, 2017

This PR refactors the ordered_hash_spec to keep with convention of the rest of the suite and added a few new specs.

There was a few issues i felt need addressing in this spec.

wrap the described behaviour in describe blocks with the method name that is being tested.
Don't use an instance variable as the test subject and don't depend on the state of the subject from previous specs

Thanks


          refactor ordered_hash_spec to keep with convention of the rest of the…

82f2423

… suite and added a few new specs

rafaelfranca merged commit 4f83b3f into rails:master

Member

rafaelfranca commented Jun 20, 2017

Awesome refactoring

colby-swandale deleted the refactor-ordered-hash-spec branch

June 20, 2017 21:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet