Updates so things work with frozen string literals #567
Conversation
|
With regards to the stdlib bug (net/protocol) - looks like it's fixed in trunk, though has not (yet) been backported into the next 2.4.x release. I'm happy to add the pragma comment (in this PR or a new one) to at least ensure regressions aren't introduced, if you'd like? |
|
Maybe just add the magic comment to the Thor source files? |
|
@segiddins: I'm certainly happy to make that change if it's the maintainers' preference, just didn't wish to presume, because it involves editing pretty much every file, and then needs to be remembered for any files that get added to the project further down the track. |
| @@ -340,7 +340,8 @@ def capture(*args) | |||
| with_output_buffer { yield(*args) } | |||
| end | |||
|
|
|||
| def with_output_buffer(buf = "") #:nodoc: | |||
| def with_output_buffer(buf = "".dup) #:nodoc: | |||
| raise "No: #{buf}" if buf.frozen? | |||
There was a problem hiding this comment.
Maybe a better descriptive error here. Also I think the exception should be an ArgumentError
There was a problem hiding this comment.
Thanks @rafaelfranca - that was actually a debugging line that I shouldn't have committed in the first place. Have kept the raise, using ArgumentError, and put in a more useful error message.
Previous line was actually debugging that shouldn't have been committed. This is much better.
These changes get Thor working when frozen string literals are enabled.
Regarding test suite dependencies and their compatibility with frozen string literals:
rspec-core,rspec-expectations, etc).simplecovand its dependencysimplecov-htmlare compatible in their latest git commits.