Add :case-insensitive flag to allow case-insensitive matching for :limited_to options 🌈 #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickjonesdotca
approved these changes
Jan 31, 2019
devanhurst
changed the title
rafaelfranca
requested changes
Nov 15, 2019
lib/thor/shell/basic.rb
Outdated
| say("Your response must be one of: [#{answers}]. Please try again.") unless correct_answer | ||
| end | ||
| correct_answer | ||
| end | ||
|
|
||
| def answer_match(possibilities, answer, case_insensitive) | ||
| return possibilities.detect{ |possibility| possibility == answer } unless case_insensitive |
There was a problem hiding this comment.
can we change this to a if/else?
There was a problem hiding this comment.
You're right; this isn't really a guard clause. I was all about guard clauses when I wrote this.
spec/shell/basic_spec.rb
Outdated
| flavors = %w(strawberry chocolate vanilla) | ||
| expect($stdout).to receive(:print).with("Your response must be one of: [strawberry, chocolate, vanilla]. Please try again.\n") | ||
| expect(Thor::LineEditor).to receive(:readline).with('What\'s your favorite Neopolitan flavor? [strawberry, chocolate, vanilla] ', :limited_to => flavors).and_return("moose tracks", "chocolate") | ||
| expect(shell.ask('What\'s your favorite Neopolitan flavor?', :limited_to => flavors)).to eq("chocolate") | ||
| end | ||
|
|
||
| #this one |
There was a problem hiding this comment.
Suggested change
| #this one |
|
@rafaelfranca Changes addressed. Saw some seemingly unrelated test failures; they're persistent after rebasing off master. Seen these ones before? |
|
Thank you. Yeah. They are from a PR that I just merged. I'll fix them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all,
After using thor a bit, I thought it'd be useful to be able to match a limited_to option case-insensitively. I often use it for [y/n] prompts, but having the prompt list out all the possibilities [y, Y, n, N, yes, YES, no, NO], for instance, doesn't looks so great. Adding case-insensitive matching allows me to simplify that prompt to [y, yes, n, no].
After reading the contributing guidelines, I see you'd like documentation updated, though documentation doesn't appear to be in the repo, but in a wiki instead. Let me know if there's anything you'd like to see added to this PR to move forward with it.
Thanks!