Suppress URI.open warning in Ruby 2.7
#677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR suppresses the follwoing warning in Ruby 2.7 ```console % ruby -v ruby 2.7.0dev (2019-09-14T09:21:37Z master 39c37acf86) [x86_64-darwin17] % bundle exec thor spec (snip) /Users/koic/src/github.com/erikhuda/thor/lib/ty ./Users/koic/src/github.com/erikhuda/thor/lib/thor/actions/file_manipulation.rb:89: warning: calling URI.open via Kernel#open is deprecated, call URI.open directly ``` cf ruby/ruby@05aac90.
koic
force-pushed
the
suppress_uri_open_warning_in_ruby27
branch
from
373ddb3
to
aabc989
Compare
| require "open-uri" | ||
| URI.send(:open, source) { |input| input.binmode.read } |
There was a problem hiding this comment.
It uses send method because this is a private method in Ruby 2.4 and lower.
Ruby 2.5
% ruby -ropen-uri -ve 'URI.open("https://github.com/erikhuda/thor")'
ruby 2.5.6p201 (2019-08-28 revision 67796) [x86_64-darwin17]Ruby 2.4
% ruby -ropen-uri -ve 'URI.open("https://github.com/erikhuda/thor")'
ruby 2.4.7p357 (2019-08-28 revision 67796) [x86_64-darwin17]
-e:1:in `<main>': private method `open' called for URI:Module (NoMethodError)
kyanny
added a commit
to kyanny/sunzi
that referenced
this pull request
Feb 25, 2022
Thor as of v0.20.x relied on `open-uri` that was deprecated since Ruby version 3. https://github.com/ruby/ruby/blob/v3_0_0/NEWS.md#compatibility-issues Thor v1.x uses `URI.open` so that it is compatible with Ruby 3.x. rails/thor#677
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suppresses the follwoing warning in Ruby 2.7
cf ruby/ruby@05aac90.