Respect the updated NO_COLOR specification #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderjoe
referenced
this pull request
Aug 7, 2022
Respect the declaration of the of the NO_COLOR environment variable as a sign that color output should be suppressed in he tool. This informal standard is described at https://no-color.org
Since implementation the NO_COLOR specification has changed. Previously if NO_COLOR was set in the environment it should be respected regardless of value. In the new updated specification NO_COLOR should only be respected if set to any non-empty string. See this comment thread on the original commit for more information. 21e6568#r80414525 Fixes #795
New versions of webmock released within the last month have adopted the ruby 2.4 method invocation syntax of &. but the tested ruby versions do not support it. This commit resolves the problem by conditionally bundling either the older version of webmock or newer versions based on the current ruby version.
|
I think it is fine to merge this. I'll make sure this is included in the changelog. |
|
Thank you very much for your help @rafaelfranca :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since implementation the NO_COLOR specification has changed. Previously
if NO_COLOR was set in the environment it should be respected regardless
of value. In the new updated specification NO_COLOR should only be
respected if set to any non-empty string.
See this comment thread on the original commit for more information.
21e6568#r80414525
Fixes #795