Skip to content

Commit

Permalink
Update Changelog and README for Webpacker on Windows
Browse files Browse the repository at this point in the history
Do not generate batch files when installing
  • Loading branch information
soundasleep committed Jul 24, 2017
1 parent b480fa6 commit 34d8d4c
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
host: localhost
```
- On Windows, `ruby bin/webpacker` and `ruby bin/webpacker-dev-server` will now bypass yarn, and execute via `node_modules/.bin` directly - [#584](https://github.com/rails/webpacker/pull/584)

### Breaking changes

- Add `compile` option to `config/webpacker.yml` for configuring lazy compilation of packs when a file under tracked paths is changed [#503](https://github.com/rails/webpacker/pull/503). To enable expected behavior, update `config/webpacker.yml`:
Expand Down
12 changes: 12 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ in which case you may not even need the asset pipeline. This is mostly relevant
- [Error: listen EADDRINUSE 0.0.0.0:8080](#error-listen-eaddrinuse-00008080)
- [throw er; // Unhandled 'error' event](#throw-er--unhandled-error-event)
- [webpack or webpack-dev-server not found](#webpack-or-webpack-dev-server-not-found)
- [Running Webpack on Windows](#running-webpack-on-windows)
- [Wishlist](#wishlist)
- [License](#license)

Expand Down Expand Up @@ -1185,6 +1186,17 @@ bundle config --delete bin
./bin/rails app:update:bin # or rails app:update:bin
```

##### Running Webpack on Windows

If you are running Webpack on Windows, your command shell may not be able to interpret the preferred interpreter
for the scripts generated in `bin/webpack` and `bin/webpack-dev-server`. Instead you'll want to run the scripts
manually with Ruby:

```
C:\path>ruby bin\webpack
C:\path>ruby bin\webpack-dev-server
```

## Wishlist

- HMR - [#188](https://github.com/rails/webpacker/issues/188)
Expand Down
1 change: 0 additions & 1 deletion lib/install/bin/webpack-dev-server.bat.tt

This file was deleted.

1 change: 0 additions & 1 deletion lib/install/bin/webpack.bat.tt

This file was deleted.

0 comments on commit 34d8d4c

Please sign in to comment.