Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asset_pack_path + HMR fix; Closes rails/webpacker#1171 #1172

Merged
merged 1 commit into from
Jan 12, 2018
Merged

asset_pack_path + HMR fix; Closes rails/webpacker#1171 #1172

merged 1 commit into from
Jan 12, 2018

Conversation

timonbandit
Copy link
Contributor

Fixed error with asset_pack_path and asset_pack_url helpers problem with CSS when HMR is enabled.
#1171

@gauravtiwari gauravtiwari merged commit c46d751 into rails:master Jan 12, 2018
@gauravtiwari
Copy link
Member

thanks 🍰

@javan
Copy link
Contributor

javan commented Jan 12, 2018

This change is going to impact production apps negatively. Every asset_pack_{path,url} will make a network request via

webpacker/lib/webpacker/dev_server.rb

Lines 12 to 13 in c46d751

def running?
Socket.tcp(host, port, connect_timeout: connect_timeout).close

@javan javan mentioned this pull request Jan 12, 2018
Closed
@javan
Copy link
Contributor

javan commented Jan 12, 2018

Also, it doesn't feel appropriate to disable asset_pack_{path,url} to fix a CSS issue. Unless those helpers are only intended for CSS asset paths? If so they should be renamed as such?

kawikadkekahuna added a commit to wealthfit/webpacker that referenced this pull request Jan 29, 2018
@kawikadkekahuna
Merge branch 'master' of https://github.com/rails/webpacker
a69ddef 
* 'master' of https://github.com/rails/webpacker: (21 commits)
  Update Ruby versions on Travis CI (rails#1230)
  Make rubocop happy
  Fix asset helper for non-css assets in hmr mode
  CSP warning for Rails 5.2
  use 2 spaces for indentation in template injection
  Update README.md (rails#1198)
  Remove duplicate yarn-error.log (rails#1197)
  3.2.1
  Revert file loader (rails#1196)
  Update default extensions and move to installer (rails#1181)
  Gitignore (rails#1195)
  Update uglify plugin (rails#1194)
  Fixes Vue root instance initialization (rails#1187)
  Return false in production environments (rails#1179)
  Fix url loader doc[ci skip] (rails#1183)
  Use inject_into_file to support rails 4.2
  Update gems and npm deps (rails#1180)
  asset_pack_path + HMR fix; Closes rails#1171 (rails#1172)
  enhance CHANGELOG.md (rails#1170)
  CI against Ruby 2.5.0
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timonbandit @gauravtiwari @javan