Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom RAILS_ENV #1277

Closed
wants to merge 1 commit into from
Closed

Allow custom RAILS_ENV #1277

wants to merge 1 commit into from

Conversation

yskkin
Copy link

@yskkin yskkin commented Feb 16, 2018

When executing RAILS_ENV=staging bin/rails assets:precompile, following error is raised. This PR fix it.

[..snip..]
Webpacker is installed 🎉 🍰
Using /var/www/myapp/releases/20180216111626/config/webpacker.yml file for setting up webpack paths
Compiling…
Compilation failed:

/var/www/myapp/releases/20180216111626/node_modules/@rails/webpacker/package/config.js:15
  delete defaultConfig.extensions
  ^

TypeError: Cannot convert undefined or null to object
    at Object.<anonymous> (/var/www/myapp/releases/20180216111626/node_modules/@rails/webpacker/package/config.js:15:3)
    at Module._compile (module.js:641:30)
    at Object.Module._extensions..js (module.js:652:10)
    at Module.load (module.js:560:32)
    at tryModuleLoad (module.js:503:12)
    at Function.Module._load (module.js:495:3)
    at Module.require (module.js:585:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/var/www/myapp/releases/20180216111626/node_modules/@rails/webpacker/package/rules/babel.js:2:24)
    at Module._compile (module.js:641:30)
rake stderr: Nothing written

@doits
Copy link
Contributor

doits commented Feb 16, 2018

Not that easy, dupe of #1265 ;-)

@yskkin
Copy link
Author

yskkin commented Feb 16, 2018

I should have searched PR more thoroughly 🙇

@yskkin yskkin closed this Feb 16, 2018
@yskkin yskkin deleted the custom_env branch February 16, 2018 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants