Remove compilation digest file if webpack command fails #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @rossta 👍 |
gauravtiwari
pushed a commit
that referenced
this pull request
Apr 29, 2018
hallelujah
added a commit
to 3scale/porta
that referenced
this pull request
Oct 8, 2018
Fixed in upstream rails/webpacker#1399 Please upgrade to 4.0 when it is released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1398
If the webpack compilation step fails, I believe the safest thing to do would be to remove the previously recorded compilation digest file so Webpacker doesn't get in the way of what could be a successful retry.