Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assets clean step #2391

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Fix assets clean step #2391

merged 1 commit into from
Dec 9, 2019

Conversation

tachyons
Copy link
Contributor

@tachyons tachyons commented Dec 9, 2019

File.exists? return true for directories and it is causing issue in assets clean step

rake aborted!
Errno::EISDIR: Is a directory @ apply2files - /home/circleci/project/public/packs-test/js
/home/circleci/project/vendor/bundle/ruby/2.6.0/gems/webpacker-4.2.1/lib/webpacker/commands.rb:11:in `delete'

@tachyons
Fix assets clean
8eee126 
File.exists? return true for directories and it is causing issue in assets clean step
@tachyons tachyons mentioned this pull request Dec 9, 2019
Merged
@gauravtiwari gauravtiwari merged commit 995f1ed into rails:master Dec 9, 2019
@tachyons tachyons deleted the patch-1 branch December 9, 2019 11:54
@gauravtiwari
Copy link
Member

Made a new release - 4.2.2

@gauravtiwari
Copy link
Member

thanks for testing 🙏

@mishaschwartz mishaschwartz mentioned this pull request Dec 9, 2019
Merged
This was referenced Mar 9, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tachyons @gauravtiwari