Setup test with initial test cases #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.travis.yml
Outdated
| @@ -12,10 +12,12 @@ cache: | |||
|
|
|||
| install: | |||
| - gem install rubocop | |||
| - gem install rake | |||
There was a problem hiding this comment.
You are running bundle exec rake and rake isn't part of the Gemfile. Perhaps, add both rake and rubocop as dependencies of the Gem.
There was a problem hiding this comment.
gem "rake", ">= 11.1"
gem "rubocop", ">= 0.47", require: false
|
Thx @gauravtiwari for the feedback. Sorry that this PR take more commits than I expected. |
Gemfile
Outdated
|
|
||
| gem "rails" | ||
| gem "rake", ">= 11.1" | ||
| gem "minitest", "~> 5.0" |
There was a problem hiding this comment.
Lets move this to :test group -
group :test do
gem "minitest", "~> 5.0"
end
|
@gauravtiwari I updated the PR. |
|
Looks good to me @kimquy 👍 🍰 @rafaelfranca Please take a look when you have a chance. |
rafaelfranca
requested changes
Apr 20, 2017
test/env_test.rb
Outdated
|
|
||
| class EnvTest < Minitest::Test | ||
| def test_current_env | ||
| assert Webpacker::Env.current == "production" |
test/env_test.rb
Outdated
| end | ||
|
|
||
| def test_env_is_development? | ||
| refute Webpacker::Env.development? |
test/env_test.rb
Outdated
|
|
||
| def test_file_path | ||
| correct_path = File.join(File.dirname(__FILE__), "config", "webpack", "paths.yml").to_s | ||
| assert Webpacker::Env.file_path.to_s == correct_path |
| end | ||
| end | ||
|
|
||
| TestApp::Application.initialize! |
There was a problem hiding this comment.
Do you need an application?
There was a problem hiding this comment.
@rafaelfranca Yes. it needs the Application!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.