Do not fail trying to append_to_file which does not exist

[nfedyashev]

Steps to reproduce:

• generate a new rails app with (--skip-git) argument
• add "webpacker" gem to Gemfile
• Run webpacker:install

Expected result:

Successful completion of webpacker:install generator call

Actual result:

rails webpacker:install
Creating javascript app source directory
      create  app/javascript
      create  app/javascript/packs/application.js
Copying binstubs
       exist  bin
      create  bin/webpack-dev-server
      create  bin/webpack-watcher
      create  bin/webpack
      create  bin/yarn
Copying webpack core config and loaders
      create  config/webpack
      create  config/webpack/configuration.js
      create  config/webpack/development.js
      create  config/webpack/development.server.js
      create  config/webpack/development.server.yml
      create  config/webpack/paths.yml
      create  config/webpack/production.js
      create  config/webpack/shared.js
      create  config/webpack/test.js
      create  config/webpack/loaders
      create  config/webpack/loaders/assets.js
      create  config/webpack/loaders/babel.js
      create  config/webpack/loaders/coffee.js
      create  config/webpack/loaders/erb.js
      create  config/webpack/loaders/sass.js
      create  .postcssrc.yml
      append  .gitignore
rails aborted!
Errno::ENOENT: No such file or directory @ rb_sysopen - /Users/nfedyashev/Projects/hello_world/.gitignore
/Users/nfedyashev/.gem/ruby/2.4.0/gems/thor-0.19.4/lib/thor/actions/inject_into_file.rb:95:in `binread'
/Users/nfedyashev/.gem/ruby/2.4.0/gems/thor-0.19.4/lib/thor/actions/inject_into_file.rb:95:in `replace!'
/Users/nfedyashev/.gem/ruby/2.4.0/gems/thor-0.19.4/lib/thor/actions/inject_into_file.rb:56:in `invoke!'
/Users/nfedyashev/.gem/ruby/2.4.0/gems/thor-0.19.4/lib/thor/actions.rb:95:in `action'
/Users/nfedyashev/.gem/ruby/2.4.0/gems/thor-0.19.4/lib/thor/actions/inject_into_file.rb:27:in `insert_into_file'
/Users/nfedyashev/.gem/ruby/2.4.0/gems/thor-0.19.4/lib/thor/actions/file_manipulation.rb:180:in `append_to_file'
/usr/local/Cellar/rbenv/1.1.0/versions/2.4.1/lib/ruby/gems/2.4.0/bundler/gems/webpacker-814cabae36da/lib/install/template.rb:14:in `apply'
/Users/nfedyashev/.gem/ruby/2.4.0/gems/thor-0.19.4/lib/thor/actions.rb:224:in `instance_eval'
/Users/nfedyashev/.gem/ruby/2.4.0/gems/thor-0.19.4/lib/thor/actions.rb:224:in `apply'
/Users/nfedyashev/.gem/ruby/2.4.0/gems/railties-5.0.2/lib/rails/tasks/framework.rake:15:in `block (2 levels) in <top (required)>'
/Users/nfedyashev/.gem/ruby/2.4.0/gems/railties-5.0.2/lib/rails/commands/rake_proxy.rb:14:in `block in run_rake_task'
/Users/nfedyashev/.gem/ruby/2.4.0/gems/railties-5.0.2/lib/rails/commands/rake_proxy.rb:11:in `run_rake_task'
/Users/nfedyashev/.gem/ruby/2.4.0/gems/railties-5.0.2/lib/rails/commands/commands_tasks.rb:51:in `run_command!'
/Users/nfedyashev/.gem/ruby/2.4.0/gems/railties-5.0.2/lib/rails/commands.rb:18:in `<top (required)>'
./bin/rails:4:in `require'
./bin/rails:4:in `<main>'
Tasks: TOP => app:template
(See full trace by running task with --trace)

[gauravtiwari]

@nfedyashev Thanks for the fix. If you could make rubocop happy I will merge this in 👍 There seems to be an extra whitespace on line 20 in template.rb

[nfedyashev]

@gauravtiwari sorry about that! The commit has just been updated

[gauravtiwari]

Lets format it like this so, it's all nicely aligned :)

if File.exists?(".gitignore")
  append_to_file ".gitignore", <<-EOS
  /public/packs
  /node_modules
  EOS
end

[nfedyashev]

It is nicely aligned but the content of that string is now different than what it was

[gauravtiwari]

Yepp, I mean that we align that string block inline with append_to_file so, it's all in one line 👍 At the moment there is 2 whitespace for append_to_file, but none for string block

[gauravtiwari]

thanks @nfedyashev 👍 🍰

[nfedyashev]

@gauravtiwari I'm sorry but my job here was to fix the bug so that it doesn't fail if .gitignore is missing.
I wasn't going to change the content that's being appended to the file.

Try it locally:

➜  webpacker cat pull-request.rb
x1 =  <<-EOS
/public/packs
/node_modules
EOS

if true
    x2 = <<-EOS
    /public/packs
    /node_modules
    EOS
end

puts x1
puts x2
raise (x1 == x2).to_s

➜  webpacker  ruby pull-request.rb
/public/packs
/node_modules
    /public/packs
    /node_modules
pull-request.rb:15:in `<main>': false (RuntimeError)

[gauravtiwari]

@nfedyashev Sorry, you were right 👍 My bad, just reverted the change :)