Use rails-5 branch for shoulda-matchers to remove deprecation warning #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ning See issue here: thoughtbot/shoulda-matchers#933 See fix here: thoughtbot/shoulda-matchers#943 DEPRECATION WARNING: #tables currently returns both tables and views. This behavior is deprecated and will be changed with Rails 5.1 to only return tables. Use #data_sources instead.
|
sorry, deleted that branch by accident. |
|
Also, i just realized my commit message may cause confusion since this project has a 'rails5' branch. The 'rails-5' branch I'm referring to in the message is a branch in the shoulda-matchers repo: https://github.com/thoughtbot/shoulda-matchers/tree/rails-5 |
|
I normally try to avoid git-sourced gems, but who knows when a new proper release of shoulda-matchers is gonna come out. Let's do it. 😎 |
|
Sweet ⚡️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue here: thoughtbot/shoulda-matchers#933
See fix here: thoughtbot/shoulda-matchers#943
DEPRECATION WARNING: #tables currently returns both tables and views. This behavior is deprecated and will be changed with Rails 5.1 to only return tables. Use #data_sources instead.