Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of activesupport dependency #230

Merged
merged 5 commits into from
Jun 28, 2019
Merged

Get rid of activesupport dependency #230

merged 5 commits into from
Jun 28, 2019

Conversation

pyromaniac
Copy link
Contributor

Trying to get rid of this dependency, it is completely unnecessary.

@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@pyromaniac
Copy link
Contributor Author

@pkuczynski hey, can you please take a look on this PR and merge if possible? Also, I can't really understand what Codacy wants from me.

@pkuczynski pkuczynski changed the title Get rid of AS dependency Get rid of activesupport dependency Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@pkuczynski
Copy link
Member

Looks good to me! waiting for the tests to pass :) I turned off Codacy as it was duplicating code climate

@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@pkuczynski pkuczynski added this to the 2.0.1 milestone Jun 27, 2019
@pkuczynski
Copy link
Member

@rdubya what do you think about this one?

@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@rubyconfig rubyconfig deleted a comment Jun 27, 2019
@pyromaniac
Copy link
Contributor Author

Perfect, not sure why codeclimate doesn't run fully thouh

@rdubya
Copy link
Contributor

rdubya commented Jun 28, 2019

@pkuczynski looks good to me

@pyromaniac
Copy link
Contributor Author

Guys, can you please merge it? Really would like to see it merged :) Thanks!

@pkuczynski
Copy link
Member

What's most important is that all test pass! I will merge it then :) Thanks for your work! @pyromaniac maybe you would like to become a contributor?

@pkuczynski pkuczynski merged commit 06e355c into rubyconfig:master Jun 28, 2019
@pyromaniac pyromaniac deleted the drop-activesupport-dep branch June 29, 2019 09:43
@pyromaniac
Copy link
Contributor Author

I'd love to but I'm going to be a bad contributor anyway. I don't really have time even for my OSS unfortunately nowadays :(

@pkuczynski
Copy link
Member

I know the feeling. Have little time myself and what's worse is that I shifted away from Ruby towards NodeJS. Still, occasional contributor is better than no contributor at all. So maybe you would agree to become such one? :) Especially if you stick to Ruby world...

@pyromaniac
Copy link
Contributor Author

Let's give it a try

@pkuczynski
Copy link
Member

Cool! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants