-
-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of activesupport dependency #230
Get rid of activesupport dependency #230
Conversation
@pkuczynski hey, can you please take a look on this PR and merge if possible? Also, I can't really understand what Codacy wants from me. |
Looks good to me! waiting for the tests to pass :) I turned off Codacy as it was duplicating code climate |
@rdubya what do you think about this one? |
Perfect, not sure why codeclimate doesn't run fully thouh |
@pkuczynski looks good to me |
Guys, can you please merge it? Really would like to see it merged :) Thanks! |
What's most important is that all test pass! I will merge it then :) Thanks for your work! @pyromaniac maybe you would like to become a contributor? |
I'd love to but I'm going to be a bad contributor anyway. I don't really have time even for my OSS unfortunately nowadays :( |
I know the feeling. Have little time myself and what's worse is that I shifted away from Ruby towards NodeJS. Still, occasional contributor is better than no contributor at all. So maybe you would agree to become such one? :) Especially if you stick to Ruby world... |
Let's give it a try |
Cool! Thanks :) |
Trying to get rid of this dependency, it is completely unnecessary.