Use flat_map rather than map.flatten #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agree - http://gistflow.com/posts/578-use-flat_map-instead-of-map-flatten @glittershark, can you add this change to CHANGELOG.md? |
|
Sure! Would you rather that in a separate commit or squashed into one? |
|
"squashed into one" please 👍 |
glittershark
force-pushed
the
flat-map-not-map-flatten
branch
from
03f140e
to
35a8846
Compare
|
done! |
le0pard
added a commit
that referenced
this pull request
Jun 16, 2015
Use flat_map rather than map.flatten
|
Thanks! |
This is a small performance and readability boost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small performance and readability boost.