Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] wallet doesn't receive signature request if it is killed or after a while of initial connection #3870

Closed
intergalacticspacehighway opened this issue Aug 1, 2022 · 8 comments

Comments

@intergalacticspacehighway

Current Behavior

Hi all!

The below video shows the demo of the issue.

RPReplay_Final1658820009.mov

I think it fails to listen to the initial deep link signature request on app start.

Expected Behavior

The wallet app should respond to the signature request prompt on app restarts.

Steps To Reproduce

  1. Connect the wallet and keep the wallet app open, sign methods work as expected.
  2. Kill the app and try calling sign method. The app doesn't show the signature prompt.

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)

https://github.com/intergalacticspacehighway/wagmi-disconnected-repro

@intergalacticspacehighway
Copy link
Author

also, I noticed that same behavior happens with metamask wallet 😕. It is consistently reproducible on my end.

@intergalacticspacehighway
Copy link
Author

intergalacticspacehighway commented Aug 1, 2022

@intergalacticspacehighway
Copy link
Author

Looks related - facebook/react-native#32350

@intergalacticspacehighway
Copy link
Author

looks like the signature requests are not dependent on deeplinks. Maybe something's wrong with initializing listener? 🤔
https://github.com/rainbow-me/rainbow/blob/develop/src/redux/walletconnect.ts#L501

@intergalacticspacehighway
Copy link
Author

A related issue so sharing my findings here, wallet stops responding to the signature requests after a while (maybe 1-2 days of connection or sometimes sooner). I am trying to press Sign message in the video below. Please ignore the horrible UI.

RPReplay_Final1659430983.MP4

WalletConnect websocket connection is sending the data to it's bridge server so I think the problem could be either in its relaying end or the wallet's receiving end.

Screenshot 2022-08-02 at 2 32 28 PM

@intergalacticspacehighway
Copy link
Author

It works seamlessly after disconnecting and connecting. Also, it establishes a new socket connection. It appears to me that either WalletConnect or wallet kills the session but the state is still connected.

RPReplay_Final1659431760.MP4

Screenshot 2022-08-02 at 2 47 23 PM

@intergalacticspacehighway intergalacticspacehighway changed the title [bug] wallet doesn't receive signature request if it is killed [bug] wallet doesn't receive signature request if it is killed or after a while of initial connection Aug 2, 2022
@intergalacticspacehighway
Copy link
Author

message from pedro. Exciting that it seems to be reliable on v2.
In the meantime, can we work on some acknowledgment from the wallet in the above scenario?

Screenshot 2022-08-03 at 12 40 52 PM

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant