This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
fix: turn autoConnect off till we identify signature requests bug #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intergalacticspacehighway
requested review from
axeldelafosse and
alantoa
as code owners
|
Deployment failed with the following error: |
PR Preview - StorybookThis pull request preview deployment is now available. ✅ Preview: exp+io.showtime.storybook://expo-development-client/?url=https://u.expo.dev/e77d5b68-bb27-45da-aa5c-96c1fdbf6706&channel-name=pr-1343 Comment ID: |
PR Preview - AppThis pull request preview deployment is now available. ✅ Preview: exp+io.showtime.development://expo-development-client/?url=https://u.expo.dev/45cbf5d5-24fe-4aa6-9580-acf540651abd&channel-name=pr-1343 Comment ID: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Wallets sometimes do not respond to signature requests even If it's in connected state.
How
Set
autoConnectto false, user will be shown connect button on trying to drop/claim.Test Plan
Login and test claim and drop, kill the app, try to claim and drop
Aside
This issue seems to be related rainbow-me/rainbow#3870, there are also some instances when the wallet is shown to be in a connected state but it doesn't respond to signature requests.