Backups V2 Follow-up Fixes / Improvements #6213
Draft
+1,481
−1,899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
changed the title
walmat
commented
Nov 8, 2024
…nbow into @matthew/APP-1297
… is not storing proper data, and create new backup every time the user wants to backup
walmat
commented
Nov 18, 2024
Comment on lines
+85
to
+86
| <Portal /> | ||
| <PortalConsumer /> |
There was a problem hiding this comment.
These are now no longer re-rendering the entire app when re-rendering
walmat
commented
Nov 18, 2024
| </Portal> | ||
| <Portal /> | ||
| <PortalConsumer /> | ||
| <BackupsSync /> |
There was a problem hiding this comment.
In charge of initial backup store sync on mount
walmat
commented
Nov 18, 2024
Comment on lines
+92
to
+105
| const AppWithRedux = connect<AppProps, AppDispatch, AppProps, AppState>( | ||
| state => ({ | ||
| walletReady: state.appState.walletReady, | ||
| }), | ||
| null, | ||
| null, | ||
| { | ||
| areStatesEqual: (next, prev) => { | ||
| // Only update if walletReady actually changed | ||
| return next.appState.walletReady === prev.appState.walletReady; | ||
| }, | ||
| areOwnPropsEqual: shallowEqual, | ||
| } | ||
| )(memo(App)); |
There was a problem hiding this comment.
we only really want to re-render the App when walletReady has changed.. this fixes that
walmat
commented
Nov 18, 2024
There was a problem hiding this comment.
this logic was moved into backupStore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1297
What changed (plus any additional context for devs)
Currently there is multiple places this hook is used, so my hunch is the useState variable
passwordwas being wiped between uses and causing issues.Screen recordings / screenshots
What to test