Fix app store deep links in dapp browser #6267
Open
+36
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbbb
commented
Nov 15, 2024
| @@ -6,6 +6,11 @@ export const HTTP = 'http://'; | |||
| export const HTTPS = 'https://'; | |||
| export const RAINBOW_HOME = 'RAINBOW_HOME'; | |||
|
|
|||
| export const IOS_APP_STORE_URL_PREFIXES = ['itms-apps://', 'itms-appss://', 'https://itunes.apple.com', 'https://apps.apple.com']; | |||
| export const ANDROID_APP_STORE_URL_PREFIXES = ['market://', 'https://play.google.com/store', 'https://play.google.com/store/apps']; | |||
There was a problem hiding this comment.
redundant prefix only need https://play.google.com/store
Comment on lines
+15
to
+18
| export function isMissingValidProtocol(url: string): boolean { | ||
| return !url.startsWith(HTTP) && !url.startsWith(HTTPS); | ||
| } | ||
|
|
There was a problem hiding this comment.
Can remove this version and use isMissingValidProtocolWorklet everywhere. Don't need to duplicate it as the 'worklet'; directive just gets ignored if a worklet is called from the JS thread.
Could do the same for isValidURL, normalizeURL, and generateUniqueId while you're in here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1833
What changed (plus any additional context for devs)
This does not handle
Screen recordings / screenshots
RPReplay_Final1731628405.mov
What to test
on iOS, must test on physical device.