-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for translating RainLab.Pages MenuItem properties #590
Conversation
@LukeTowers We can include the url field as well, all other content is irrelevant in the menu. CMS/Static pages URLs are translated on their own. Frankly, translating the title and URL will solve the problem for a lot of people. What other cases do you think of? |
@mjauvin how does it handle the other reference types? |
@LukeTowers it doesn't they are handled on their own (like CMS/Static pages translate their URL on their own for example) |
@LukeTowers @bennothommo, I am ready to merge this, it's been tested with and without the new related changes for RainLab.Pages. and does not cause problems. |
LGTM! |
I made an update today and now I see the option to translate Menu but I can not save the changes. How can it be? |
What version of RainLab.Pages plugin do you have? You need v1.3.6 |
You need to enable `edgeUpdates => true` in config/cms.php but since you
have version 1.7.3 of the translate plugin, that should already be
enabled...
…On Wed, Oct 7, 2020 at 3:10 PM sagjatome ***@***.***> wrote:
What version of RainLab.Pages plugin do you have? You need v1.3.6
1.3.5 but i do not get any updates...
[image: image]
<https://user-images.githubusercontent.com/59820668/95376473-6f208c80-08e1-11eb-8515-a6ce6ab299ba.png>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#590 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPLTPTY4XWP3GI5XN53UEDSJS4JBANCNFSM4PS7N7ZA>
.
--
Marc
|
Really, I do, Thanks I lot, mjauvin
|
Thank you for adding this feature finally !!! Now menu item properties can be completely translated. Well done |
Complements rainlab/pages-plugin#445
pages.menu.referencesGenerated
event to replace MenuItem title/url with their translation (if available)