Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greek language added #617

Merged
merged 6 commits into from
Oct 20, 2020
Merged

Greek language added #617

merged 6 commits into from
Oct 20, 2020

Conversation

apapad0
Copy link
Contributor

@apapad0 apapad0 commented Oct 19, 2020

Could you please label my request as hacktoberfest-accepted?

@mjauvin
Copy link
Contributor

mjauvin commented Oct 20, 2020

Please, rename file to lang/gr/lang.php (no .txt extension)

@mjauvin
Copy link
Contributor

mjauvin commented Oct 20, 2020

the ". php" extension is missing.

@mjauvin
Copy link
Contributor

mjauvin commented Oct 20, 2020

May I ask how you translated these strings?

@apapad0
Copy link
Contributor Author

apapad0 commented Oct 20, 2020

May I ask how you translated these strings?

Im greek. I used google translate to save time and afterwards checked if the meaning was ok. if not i modified the sentences. i matched the meaning as well as i could.

@mjauvin
Copy link
Contributor

mjauvin commented Oct 20, 2020

Excellent!

@mjauvin mjauvin added this to the 1.7.4 milestone Oct 20, 2020
@mjauvin mjauvin merged commit 531d6de into rainlab:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants