Skip to content

Commit

Permalink
Merge pull request #1 from raito-io/RAITO-1817-config-map-metadata-in…
Browse files Browse the repository at this point in the history
…formation-aws-organisation

Upgrade to CLI v0.50.0
  • Loading branch information
rmennes authored Oct 10, 2023
2 parents 1b0aa36 + 4f8177e commit b66de0a
Show file tree
Hide file tree
Showing 7 changed files with 420 additions and 169 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
go-version: '1.20'
go-version: '1.21'
cache: true

- name: Configure git for private modules
Expand All @@ -33,7 +33,7 @@ jobs:
- name: Lint
uses: golangci/golangci-lint-action@v3
with:
version: v1.52.2
version: v1.54.2

- name: Test
run: make test-coverage
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
go-version: '1.20'
go-version: '1.21'
cache: true

- name: Configure git for private modules
Expand Down
18 changes: 13 additions & 5 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ linters-settings:
gosec:
excludes:
- G404 # To be checked: Insecure random number source (rand)
- G602

stylecheck:
checks: [ "all", "-ST1003"] # ST1003: No underscores in package names should be fixed and removed?
Expand All @@ -54,14 +55,22 @@ linters-settings:
ignored-functions:
- 'math.*' # Magic number generation, should be fixed and removed?

cyclop:
max-complexity: 20
skip-tests: true
package-average: 0.0

linters:
disable-all: true
enable:
- asasalint
- bodyclose
- deadcode
- depguard
- cyclop #To be enabled in the future
# - depguard #We should create a correct config to enabe depguard
- dogsled
- dupl
- dupword
- durationcheck
- errcheck
- exportloopref
- exhaustive
Expand All @@ -71,7 +80,7 @@ linters:
- gofmt
- goimports
#- gomnd # Magic numbers should be fixed and enable gomnd,
#- gocyclo
- gocyclo
- gosec
- gosimple
- govet
Expand All @@ -83,14 +92,13 @@ linters:
- predeclared
- revive
- staticcheck
- structcheck
- stylecheck
- thelper
- tparallel
- typecheck
- unconvert
- unparam
- varcheck
- unused
- whitespace
# - wrapcheck # 3th party errors should be wrapped to not lose context
- wsl
Expand Down
2 changes: 1 addition & 1 deletion aws/identity_store.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ func NewIdentityStoreSyncer() *IdentityStoreSyncer {
return &IdentityStoreSyncer{repoProvider: newRepoProvider}
}

func (s *IdentityStoreSyncer) GetIdentityStoreMetaData(ctx context.Context) (*is.MetaData, error) {
func (s *IdentityStoreSyncer) GetIdentityStoreMetaData(_ context.Context, _ *config.ConfigMap) (*is.MetaData, error) {
logger.Debug("Returning meta data for AWS identity store")

return &is.MetaData{
Expand Down
216 changes: 216 additions & 0 deletions aws/mock_identityStoreRepository.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit b66de0a

Please sign in to comment.