Fix issue with postfixId for rolename generation

raito-io · Sep 17, 2024 · 045058a · 045058a
1 parent 297e75a
commit 045058a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/base/access_provider/sync_to_target/naming_hint/generator.go b/base/access_provider/sync_to_target/naming_hint/generator.go
@@ -116,7 +116,7 @@ func (g *uniqueNameGenerator) Generate(ap *sync_to_target.AccessProvider) (strin
 	}
 
 	if currentNumber, found := g.existingNames[name]; found {
-		postfixId := fmt.Sprintf("%[1]c%[1]c%[2]x", g.splitCharacter, currentNumber)
+		postfixId := fmt.Sprintf("%[1]c%[1]c%[2]X", g.splitCharacter, currentNumber)
 
 		if !g.constraints.UpperCaseLetters {
 			postfixId = strings.ToLower(postfixId)

diff --git a/base/access_provider/sync_to_target/naming_hint/generator_test.go b/base/access_provider/sync_to_target/naming_hint/generator_test.go
@@ -123,7 +123,7 @@ func TestUniqueGenerator_Generate_DuplicatedNames(t *testing.T) {
 
 func TestUniqueGenerator_Generate_DuplicatedNames_uppercase(t *testing.T) {
 	//Given
-	upperCaseRegex := regexp.MustCompile("[A-Z0-9_]+")
+	upperCaseRegex := regexp.MustCompile("^[A-Z0-9_]+$")
 
 	constraints := NamingConstraints{
 		UpperCaseLetters:  true,