Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close output writers in post processors #369

Conversation

rmennes
Copy link
Collaborator

@rmennes rmennes commented Sep 19, 2024

No description provided.

@rmennes rmennes requested a review from codatoz September 19, 2024 07:28
codatoz
codatoz previously approved these changes Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.61%. Comparing base (3d5f26f) to head (17d2319).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/data_source/post_processor.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #369   +/-   ##
=======================================
  Coverage   29.60%   29.61%           
=======================================
  Files         143      143           
  Lines       10143    10145    +2     
=======================================
+ Hits         3003     3004    +1     
- Misses       6802     6803    +1     
  Partials      338      338           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codatoz codatoz merged commit 6aa456e into main Sep 19, 2024
3 checks passed
@codatoz codatoz deleted the RAITO-4042-ds-import-generate-data-object-input-no-external-id-field-found-for-data-object-in-import-file branch September 19, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants