[Storage]Revert equal sign in async (Azure#13501)

rakshith91 · Sep 4, 2020 · 05ee058 · 05ee058
1 parent fb70d8d
commit 05ee058
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 134 deletions.
diff --git a/sdk/storage/azure-storage-blob/azure/storage/blob/_shared/authentication.py b/sdk/storage/azure-storage-blob/azure/storage/blob/_shared/authentication.py
@@ -79,9 +79,7 @@ def _get_canonicalized_resource(self, request):
         uri_path = urlparse(request.http_request.url).path
         try:
             if isinstance(request.context.transport, AioHttpTransport) or \
-                    isinstance(getattr(request.context.transport, "_transport", None), AioHttpTransport) or \
-                    isinstance(getattr(getattr(request.context.transport, "_transport", None), "_transport", None),
-                               AioHttpTransport):
+                    isinstance(getattr(request.context.transport, "_transport", None), AioHttpTransport):
                 uri_path = URL(uri_path)
                 return '/' + self.account_name + str(uri_path)
         except TypeError:

diff --git a/...torage-blob/tests/recordings/test_common_blob_async.test_create_blob_with_equal_sign.yaml b/...torage-blob/tests/recordings/test_common_blob_async.test_create_blob_with_equal_sign.yaml
diff --git a/sdk/storage/azure-storage-blob/tests/test_common_blob_async.py b/sdk/storage/azure-storage-blob/tests/test_common_blob_async.py
@@ -272,24 +272,6 @@ async def test_create_blob_with_question_mark(self, resource_group, location, st
         content = data.decode('utf-8')
         self.assertEqual(content, blob_data)
 
-    @GlobalStorageAccountPreparer()
-    @AsyncStorageTestCase.await_prepared_test
-    async def test_create_blob_with_equal_sign(self, resource_group, location, storage_account, storage_account_key):
-        # Arrange
-        await self._setup(storage_account, storage_account_key)
-        blob_name = '=ques=tion!'
-        blob_data = u'???'
-
-        # Act
-        blob = self.bsc.get_blob_client(self.container_name, blob_name)
-        await blob.upload_blob(blob_data)
-
-        # Assert
-        stream = await blob.download_blob()
-        data = await stream.readall()
-        self.assertIsNotNone(data)
-        content = data.decode('utf-8')
-        self.assertEqual(content, blob_data)
 
     @GlobalStorageAccountPreparer()
     @AsyncStorageTestCase.await_prepared_test

diff --git a/sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_shared/authentication.py b/sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_shared/authentication.py
@@ -79,9 +79,7 @@ def _get_canonicalized_resource(self, request):
         uri_path = urlparse(request.http_request.url).path
         try:
             if isinstance(request.context.transport, AioHttpTransport) or \
-                    isinstance(getattr(request.context.transport, "_transport", None), AioHttpTransport) or \
-                    isinstance(getattr(getattr(request.context.transport, "_transport", None), "_transport", None),
-                               AioHttpTransport):
+                    isinstance(getattr(request.context.transport, "_transport", None), AioHttpTransport):
                 uri_path = URL(uri_path)
                 return '/' + self.account_name + str(uri_path)
         except TypeError:

diff --git a/sdk/storage/azure-storage-file-share/azure/storage/fileshare/_shared/authentication.py b/sdk/storage/azure-storage-file-share/azure/storage/fileshare/_shared/authentication.py
@@ -79,9 +79,7 @@ def _get_canonicalized_resource(self, request):
         uri_path = urlparse(request.http_request.url).path
         try:
             if isinstance(request.context.transport, AioHttpTransport) or \
-                    isinstance(getattr(request.context.transport, "_transport", None), AioHttpTransport) or \
-                    isinstance(getattr(getattr(request.context.transport, "_transport", None), "_transport", None),
-                               AioHttpTransport):
+                    isinstance(getattr(request.context.transport, "_transport", None), AioHttpTransport):
                 uri_path = URL(uri_path)
                 return '/' + self.account_name + str(uri_path)
         except TypeError:

diff --git a/sdk/storage/azure-storage-queue/azure/storage/queue/_shared/authentication.py b/sdk/storage/azure-storage-queue/azure/storage/queue/_shared/authentication.py
@@ -79,9 +79,7 @@ def _get_canonicalized_resource(self, request):
         uri_path = urlparse(request.http_request.url).path
         try:
             if isinstance(request.context.transport, AioHttpTransport) or \
-                    isinstance(getattr(request.context.transport, "_transport", None), AioHttpTransport) or \
-                    isinstance(getattr(getattr(request.context.transport, "_transport", None), "_transport", None),
-                               AioHttpTransport):
+                    isinstance(getattr(request.context.transport, "_transport", None), AioHttpTransport):
                 uri_path = URL(uri_path)
                 return '/' + self.account_name + str(uri_path)
         except TypeError: