API Key Not Being Passed On Paged Requests (Azure#23477)

* fix for pagination bug in async calls * changelog * update recordings * update changelog
rakshith91 · Apr 7, 2022 · 0d8ca1a · 0d8ca1a
1 parent a7df8de
commit 0d8ca1a
Show file tree

Hide file tree

Showing 6 changed files with 3,664 additions and 71 deletions.
diff --git a/sdk/search/azure-search-documents/CHANGELOG.md b/sdk/search/azure-search-documents/CHANGELOG.md
@@ -7,6 +7,7 @@
 ### Breaking Changes
 
 ### Bugs Fixed
+- Fixed issue where async `search` call would fail with a 403 error when retrieving large number of documents.
 
 ### Other Changes
 

diff --git a/sdk/search/azure-search-documents/azure/search/documents/aio/_paging.py b/sdk/search/azure-search-documents/azure/search/documents/aio/_paging.py
@@ -107,7 +107,7 @@ async def _get_next_cb(self, continuation_token):
         _next_link, next_page_request = unpack_continuation_token(continuation_token)
 
         return await self._client.documents.search_post(
-            search_request=next_page_request
+            search_request=next_page_request, **self._kwargs
         )
 
     async def _extract_data_cb(self, response):  # pylint:disable=no-self-use

diff --git a/sdk/search/azure-search-documents/tests/async_tests/test_search_client_search_live_async.py b/sdk/search/azure-search-documents/tests/async_tests/test_search_client_search_live_async.py
@@ -148,3 +148,18 @@ async def _test_suggest(self, client):
             {"hotelId": "2", "text": "Cheapest hotel in town. Infact, a motel."},
             {"hotelId": "9", "text": "Secret Point Motel"},
         ]
+
+    @SearchEnvVarPreparer()
+    @search_decorator(schema="hotel_schema.json", index_batch="hotel_large.json")
+    @recorded_by_proxy_async
+    async def test_search_client_large(self, endpoint, api_key, index_name):
+        client = SearchClient(endpoint, index_name, api_key)
+        async with client:
+            await self._test_get_search_simple_large(client)
+
+    async def _test_get_search_simple_large(self, client):
+        results = []
+        async for x in await client.search(search_text = ''):
+            results.append(x)
+        assert len(results) == 60
+