Skip to content

Commit

Permalink
Skip Datalake tests that depend on most recent Blob changes (AzureSas…
Browse files Browse the repository at this point in the history
…Credential) (Azure#16129)
  • Loading branch information
tasherif-msft authored and rakshith91 committed Jan 15, 2021
1 parent 5ad295f commit fc40051
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
3 changes: 2 additions & 1 deletion sdk/storage/azure-storage-file-datalake/tests/test_file.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
# --------------------------------------------------------------------------
import unittest
from datetime import datetime, timedelta

import pytest

from azure.core import MatchConditions
Expand Down Expand Up @@ -486,6 +485,7 @@ def test_read_file_to_text(self):

@record
def test_account_sas(self):
pytest.skip("Re-enable this test after min dependency on blobs is updated.")
# SAS URL is calculated from storage key, so this test runs live only
if TestMode.need_recording_file(self.test_mode):
return
Expand Down Expand Up @@ -516,6 +516,7 @@ def test_account_sas(self):
file_client.append_data(b"abcd", 0, 4)

def test_account_sas_raises_if_sas_already_in_uri(self):
pytest.skip("Re-enable this test after min dependency on blobs is updated.")
with self.assertRaises(ValueError):
DataLakeFileClient(self.dsc.url + "?sig=foo", self.file_system_name, "foo", credential=AzureSasCredential("?foo=bar"))

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import unittest
from datetime import datetime, timedelta
import asyncio
import pytest

from azure.core import MatchConditions
from azure.core.credentials import AzureSasCredential
Expand Down Expand Up @@ -518,10 +519,12 @@ async def _test_account_sas(self):

@record
def test_account_sas_async(self):
pytest.skip("Re-enable this test after min dependency on blobs is updated.")
loop = asyncio.get_event_loop()
loop.run_until_complete(self._test_account_sas())

def test_account_sas_raises_if_sas_already_in_uri(self):
pytest.skip("Re-enable this test after min dependency on blobs is updated.")
with self.assertRaises(ValueError):
DataLakeFileClient(self.dsc.url + "?sig=foo", self.file_system_name, "foo", credential=AzureSasCredential("?foo=bar"))

Expand Down

0 comments on commit fc40051

Please sign in to comment.