-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump react-scripts from 4.0.3 to 5.0.0 #882
Bump react-scripts from 4.0.3 to 5.0.0 #882
Conversation
we need to switch |
ea55633
to
e0832a1
Compare
65bf709
to
e6cfd5a
Compare
Bumps [react-scripts](https://github.com/facebook/create-react-app/tree/HEAD/packages/react-scripts) from 4.0.3 to 5.0.0. - [Release notes](https://github.com/facebook/create-react-app/releases) - [Changelog](https://github.com/facebook/create-react-app/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/create-react-app/commits/react-scripts@5.0.0/packages/react-scripts) --- updated-dependencies: - dependency-name: react-scripts dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
e6cfd5a
to
7851f8d
Compare
Codecov Report
@@ Coverage Diff @@
## master #882 +/- ##
==========================================
+ Coverage 97.58% 97.61% +0.02%
==========================================
Files 39 39
Lines 1410 1427 +17
Branches 368 374 +6
==========================================
+ Hits 1376 1393 +17
Misses 33 33
Partials 1 1
Continue to review full report at Codecov.
|
also fix other errors: - fixed SVG errors by minifying SVGs - excluded tests from tsc checks (ran by the dev server) - removed some uneeded packages (mostly related to storybook)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joelvdavies The latter two issues are being tracked in CRA (deprecation warning: facebook/create-react-app#11860, source maps error: facebook/create-react-app#11752) - neither are causing issues right now (deprecation warning is just that - a warning and it's slated to be fixed soon, and the source maps aren't important) I'll investigate what's gone wrong with the SVG - I basically minified all the SVGs to remove all the extraneous info that's not needed, and react was now erroring over but perhaps it was too aggressive and it removed something important |
- also further minified them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed changes, CI passes, SVG issue fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed changes, CI passes, SVG issue fixed.
Bumps react-scripts from 4.0.3 to 5.0.0.
Commits
221e511
Publish5614c87
Add support for Tailwind (#11717)20edab4
fix(webpackDevServer): disable overlay for warnings (#11413)3afbbc0
Update all dependencies (#11624)f5467d5
feat(eslint-config-react-app): support ESLint 8.x (#11375)c7627ce
Update webpack and dev server (#11646)544befe
Update package.json (#11597)3880ba6
Remove dependency pinning (#11474)5cedfe4
Bump browserslist from 4.14.2 to 4.16.5 (#11476)50ea5ad
allow CORS on webpack-dev-server (#11325)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)