Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump react-scripts from 4.0.3 to 5.0.0 #882

Merged
merged 8 commits into from
Feb 8, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 15, 2021

Bumps react-scripts from 4.0.3 to 5.0.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 15, 2021
@louise-davies
Copy link
Member

we need to switch setImmediate with (fn) => setTimeout(fn, 0)

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/react-scripts-5.0.0 branch 2 times, most recently from ea55633 to e0832a1 Compare January 5, 2022 09:59
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/react-scripts-5.0.0 branch 3 times, most recently from 65bf709 to e6cfd5a Compare January 21, 2022 14:11
Bumps [react-scripts](https://github.com/facebook/create-react-app/tree/HEAD/packages/react-scripts) from 4.0.3 to 5.0.0.
- [Release notes](https://github.com/facebook/create-react-app/releases)
- [Changelog](https://github.com/facebook/create-react-app/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/create-react-app/commits/react-scripts@5.0.0/packages/react-scripts)

---
updated-dependencies:
- dependency-name: react-scripts
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/react-scripts-5.0.0 branch from e6cfd5a to 7851f8d Compare January 25, 2022 13:40
@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #882 (11acdf7) into master (d717e3c) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #882      +/-   ##
==========================================
+ Coverage   97.58%   97.61%   +0.02%     
==========================================
  Files          39       39              
  Lines        1410     1427      +17     
  Branches      368      374       +6     
==========================================
+ Hits         1376     1393      +17     
  Misses         33       33              
  Partials        1        1              
Impacted Files Coverage Δ
src/App.tsx 89.65% <0.00%> (+0.36%) ⬆️
src/routing/routing.component.tsx 100.00% <0.00%> (ø)
src/mainAppBar/mainAppBar.component.tsx 100.00% <0.00%> (ø)
src/state/reducers/scigateway.reducer.tsx 100.00% <0.00%> (ø)
src/loginPage/loginPage.component.tsx 98.51% <0.00%> (+0.02%) ⬆️
src/state/actions/scigateway.actions.tsx 97.96% <0.00%> (+0.03%) ⬆️
src/cookieConsent/cookieConsent.component.tsx 97.22% <0.00%> (+0.07%) ⬆️
src/state/middleware/scigateway.middleware.tsx 92.30% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d717e3c...11acdf7. Read the comment docs.

also fix other errors:
- fixed SVG errors by minifying SVGs
- excluded tests from tsc checks (ran by the dev server)
- removed some uneeded packages (mostly related to storybook)
Copy link
Contributor

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decal2 on the homepage no longer behaves correctly as it now stretches:
image
I also seem to be getting an error for react-floater, although react-joyride still works as far as I can tell:
image
and a deprecation warning
image

@louise-davies
Copy link
Member

@joelvdavies The latter two issues are being tracked in CRA (deprecation warning: facebook/create-react-app#11860, source maps error: facebook/create-react-app#11752) - neither are causing issues right now (deprecation warning is just that - a warning and it's slated to be fixed soon, and the source maps aren't important)

I'll investigate what's gone wrong with the SVG - I basically minified all the SVGs to remove all the extraneous info that's not needed, and react was now erroring over but perhaps it was too aggressive and it removed something important

- also further minified them
@joelvdavies joelvdavies self-requested a review February 8, 2022 09:36
joelvdavies
joelvdavies previously approved these changes Feb 8, 2022
Copy link
Contributor

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes, CI passes, SVG issue fixed.

Copy link
Contributor

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes, CI passes, SVG issue fixed.

@louise-davies louise-davies merged commit a9025c4 into master Feb 8, 2022
@louise-davies louise-davies deleted the dependabot/npm_and_yarn/react-scripts-5.0.0 branch February 8, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants