Merge pull request #96 from ralexstokes/drop-default

drop some unnecessary type constraints
ralexstokes · Jul 28, 2023 · e498c7a · e498c7a
2 parents 6dc5133 + 0af7a6e
commit e498c7a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/ssz-rs/src/lib.rs b/ssz-rs/src/lib.rs
@@ -98,7 +98,7 @@ pub trait Sized {
 
 /// `SimpleSerialize` is a trait for types
 /// conforming to the SSZ spec.
-pub trait SimpleSerialize: Serialize + Deserialize + Sized + Merkleized + Default {}
+pub trait SimpleSerialize: Serialize + Deserialize + Sized + Merkleized {}
 
 mod exports {
     pub use crate::{

diff --git a/ssz-rs/src/list.rs b/ssz-rs/src/list.rs
@@ -39,7 +39,7 @@ where
 
 impl<T, const N: usize> Default for List<T, N>
 where
-    T: SimpleSerialize + Default,
+    T: SimpleSerialize,
 {
     fn default() -> Self {
         let data = vec![];

diff --git a/ssz-rs/src/vector.rs b/ssz-rs/src/vector.rs
@@ -61,14 +61,17 @@ where
 
 impl<T, const N: usize> Default for Vector<T, N>
 where
-    T: SimpleSerialize + Default + Clone,
+    T: SimpleSerialize + Default,
 {
     fn default() -> Self {
         // SAFETY: there is currently no way to enforce statically
         // that `N` is non-zero with const generics so panics are possible.
         assert!(N > 0);
 
-        let data = vec![T::default(); N];
+        let mut data = Vec::with_capacity(N);
+        for _ in 0..N {
+            data.push(T::default());
+        }
 
         // SAFETY: panic can't happen because data.len() == N != 0; qed
         data.try_into()
@@ -216,7 +219,7 @@ where
     }
 }
 
-impl<T, const N: usize> SimpleSerialize for Vector<T, N> where T: SimpleSerialize + Clone {}
+impl<T, const N: usize> SimpleSerialize for Vector<T, N> where T: SimpleSerialize {}
 
 #[cfg(feature = "serde")]
 impl<T: SimpleSerialize + serde::Serialize, const N: usize> serde::Serialize for Vector<T, N> {